Use queue instead of memory queue in webhook send service #19390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delvh
added
type/refactoring
|
The CI fail sounds related. Somewhere in this PR, there seems to be an NPE. |
GiteaBot
added
the
lgtm/need 2
Yes, |
Gusted
reviewed
Apr 14, 2022
lunny
force-pushed
the
lunny/webhook_queue
branch
from
589173c to
96dfe20
Compare
lunny
force-pushed
the
lunny/webhook_queue
branch
from
96dfe20 to
4aa7d9e
Compare
Gusted
approved these changes
Apr 25, 2022
GiteaBot
added
lgtm/need 1
lafriks
approved these changes
Apr 25, 2022
GiteaBot
added
lgtm/done
6543
approved these changes
Apr 25, 2022
19 tasks
lunny
force-pushed
the
lunny/webhook_queue
branch
from
9962bad to
0f36ef4
Compare
lunny
force-pushed
the
lunny/webhook_queue
branch
from
93ac146 to
632dfdc
Compare
|
🚀 |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 26, 2022
* giteaofficial/main: Add a new menu in file view to open blame view and fix blame view select range bug (go-gitea#19500) Fix two UI bugs: JS error in imagediff.js, 500 error in diff/compare.tmpl [skip ci] Updated translations via Crowdin Improve Stopwatch behavior (go-gitea#18930) Pass gitRepo down to GetRawDiff, since its used for main repo and wiki (go-gitea#19461) Use queue instead of memory queue in webhook send service (go-gitea#19390) add a directory prefix `gitea-src-VERSION` to release-tar-file (go-gitea#19396)
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just found webhook send queue is still using a memory one. This PR add that and removed the unused memory queue.